Re: [PATCH] null_blk: fix validation of block size

From: John Garry
Date: Mon Jun 03 2024 - 09:54:27 EST


On 03/06/2024 00:59, Damien Le Moal wrote:
On 6/2/24 19:57, John Garry wrote:
On 01/06/2024 21:23, Andreas Hindborg wrote:
From: Andreas Hindborg<a.hindborg@xxxxxxxxxxx>

Block size should be between 512

and 4096
Or PAGE_SIZE?
PAGE_SIZE can be larger than 4096. But most drives are 512 or 4096 LBA-sized.

Sure, but maybe someone wants larger than 4096, like the LBS support.

Having said that, is there LBS support for nullb? I don't think so. I assume that PAGE_SIZE or 4096 limit would need to go for that.

Cheers,
John