Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: Ian Rogers
Date: Mon Jun 03 2024 - 12:32:37 EST


On Sat, Jun 1, 2024 at 5:07 PM <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Ian

> ---
> tools/perf/util/hisi-ptt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
> u32 pmu_type;
> };
>
> -struct hisi_ptt_queue {
> - struct hisi_ptt *ptt;
> - struct auxtrace_buffer *buffer;
> -};
> -
> static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
> {
> uint32_t head = *(uint32_t *)buf;
> --
> 2.45.1
>