Re: [PATCH] perf genelf: remove unused struct 'options'

From: Ian Rogers
Date: Mon Jun 03 2024 - 12:33:09 EST


On Sat, Jun 1, 2024 at 5:05 PM <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Ian

> ---
> tools/perf/util/genelf.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
> char name[0]; /* Start of the name+desc data */
> } Elf_Note;
>
> -struct options {
> - char *output;
> - int fd;
> -};
> -
> static char shd_string_table[] = {
> 0,
> '.', 't', 'e', 'x', 't', 0, /* 1 */
> --
> 2.45.1
>