RE: [PATCH] riscv: dts: starfive: Update flash partition layout
From: Hal Feng
Date: Tue Jun 04 2024 - 04:25:03 EST
> On 03.06.24 23:27, Heinrich Schuchardt wrote:
> On 03.06.24 17:07, matthias.bgg@xxxxxxxxxx wrote:
> > From: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> >
> > Up to now, the describe flash partition layout has some gaps.
> > Use the whole flash chip by getting rid of the gaps.
> >
> > Suggested-by: Heinrich Schuchardt <heinrich.schuchardt@xxxxxxxxxxxxx>
> > Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
>
> For flashing larger firmware like EDK II it is helpful to maximize the partition sizes.
> Thanks for sending the patch.
>
> Commit 8384087a ("riscv: dts: starfive: Add QSPI controller node for StarFive
> JH7110 SoC") https://lore.kernel.org/linux-riscv/20230804020254.291239-4-
> william.qiu@xxxxxxxxxxxxxxxx/
> introduced the current layout.
>
> CCing Starfive's U-Boot reviewers.
>
> Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@xxxxxxxxxxxxx>
We added a "reserved-data" partition because the u-boot of VF2 didn't
require a large space and users can use this partition to do something
they want.
Best regards,
Hal
>
> >
> > ---
> >
> > arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > index 8ff6ea64f0489..37b4c294ffcc5 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > @@ -321,16 +321,13 @@ partitions {
> > #size-cells = <1>;
> >
> > spl@0 {
> > - reg = <0x0 0x80000>;
> > + reg = <0x0 0xf0000>;
> > };
> > uboot-env@f0000 {
> > reg = <0xf0000 0x10000>;
> > };
> > uboot@100000 {
> > - reg = <0x100000 0x400000>;
> > - };
> > - reserved-data@600000 {
> > - reg = <0x600000 0xa00000>;
> > + reg = <0x100000 0xf00000>;
> > };
> > };
> > };