Re: [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for interrupt-names
From: Johan Hovold
Date: Tue Jun 04 2024 - 06:53:11 EST
On Tue, Jun 04, 2024 at 08:52:52AM +0200, Bartosz Golaszewski wrote:
> On Mon, May 27, 2024 at 4:45 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > There's a set of compatibles for which we set a strict list of 5 interrupt
> > names even though minItems for the interrupts property is 4. One of the
> > USB controllers on sa8775p only consumes 4 interrupts which leads to
> > dtbs_check errors. Make the last entry optional by setting minItems to 4.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > index cf633d488c3f..4251dc25ee9a 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > @@ -468,6 +468,7 @@ allOf:
> > minItems: 4
> > maxItems: 5
> > interrupt-names:
> > + minItems: 4
> > items:
> > - const: pwr_event
> > - const: hs_phy_irq
> > --
> > 2.43.0
> >
>
> Gentle ping.
As was pointed out elsewhere in this thread, there are two more
issues like introduced by the same patch which should be fixed at the
same time.
Johan