Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

[Mark Brown]

On Mon, Jun 03, 2024 at 11:26:39AM +0800, Liao, Chang wrote:

> Mark, Is your concern is that the series of pstate related macro name in
> sysregs.h are lack of self-explanatory nature, which make it diffuclt to
> understand their functionality and purpose? If so, I daft some alternative
> macro names in the code below, looking forward to your feedback, or if you
> have any proposal for making these helpers discoverable.

...

> -#define SET_PSTATE(x, r)               __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
> +#define MSR_PSTATE_ENCODE(x, r)                __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))

Possibly, yes?  TBH I was thinking of a comment but that does have "MSR"
in it so might come up in greps.  Not sure what others would prefer.

Attachment: signature.asc
Description: PGP signature