Re: [PATCH] RAS/AMD/ATL: add missing MODULE_DESCRIPTION() macro
From: Borislav Petkov
Date: Wed Jun 05 2024 - 05:42:40 EST
On Tue, Jun 04, 2024 at 07:21:59PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ras/amd/atl/amd_atl.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
> drivers/ras/amd/atl/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
> index 6dc4e06305f7..7be4982fdf19 100644
> --- a/drivers/ras/amd/atl/core.c
> +++ b/drivers/ras/amd/atl/core.c
> @@ -222,4 +222,5 @@ static void __exit amd_atl_exit(void)
> module_init(amd_atl_init);
> module_exit(amd_atl_exit);
>
> +MODULE_DESCRIPTION("AMD Address Translation Library");
> MODULE_LICENSE("GPL");
>
> ---
Applied, thanks.
Btw, I'd suggest instead of sending those piecemeal-wise, one per
driver, just group them all by subsystem and whatnot so that each
maintainer can pick it up and this new thing modpost decided to complain
about, can be taken care of without noodling through each driver
one-by-one.
Better yet: do a coccinelle patch and convert the whole tree.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette