Re: [PATCH] RAS/AMD/ATL: add missing MODULE_DESCRIPTION() macro

From: Jeff Johnson
Date: Wed Jun 05 2024 - 10:10:55 EST


On 6/5/2024 2:40 AM, Borislav Petkov wrote:
> Btw, I'd suggest instead of sending those piecemeal-wise, one per
> driver, just group them all by subsystem and whatnot so that each
> maintainer can pick it up and this new thing modpost decided to complain
> about, can be taken care of without noodling through each driver
> one-by-one.
>
> Better yet: do a coccinelle patch and convert the whole tree.

I actually did use a simple script to do a conversion locally, but the hard
part is determining what text to use for the description. So my local
conversion just added:
MODULE_DESCRIPTION("TBD");

Then, on a per-directory basis, I look at documentation in the .c files and
the Kconfig to replace the TBD with an appropriate description. And I then
create patches for that directory based upon MAINTAINERS entries.

This was the only file in drivers/ras that had an issue.

In drivers/hid there were a large number of issues.
Some of the files had specific MAINTAINERS entries so I sent them separately:
https://lore.kernel.org/all/20240604-md-hid-letsketch-v1-1-ff38ae7b4cb0@xxxxxxxxxxx/
https://lore.kernel.org/all/20240604-md-hid-lg-g15-v1-1-265b094db089@xxxxxxxxxxx/
https://lore.kernel.org/all/20240604-md-hid-logitech-dj-v1-1-560f6b3cb54b@xxxxxxxxxxx/
https://lore.kernel.org/all/20240603-md-hid-logitech-hidpp-v1-1-060f06e4529f@xxxxxxxxxxx/

I then sent a large patch for all of the remaining drivers/hid patches:
https://lore.kernel.org/all/20240604-md-hid-misc-v1-1-4f9560796f3c@xxxxxxxxxxx/