RE: [PATCH 2/7] arm64: dts: imx8qm: add mipi subsystem

[Peng Fan]

> Subject: [PATCH 2/7] arm64: dts: imx8qm: add mipi subsystem
> 
> Add irqstear, pwm and i2c in mipi subsystem.

irqsteer
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-ss-mipi.dtsi | 286
> ++++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8qm.dtsi         |   1 +
>  2 files changed, 287 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-mipi.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qm-ss-mipi.dtsi
> new file mode 100644
> index 0000000000000..bd18468923e52
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-mipi.dtsi
> @@ -0,0 +1,286 @@
> +// SPDX-License-Identifier: GPL-2.0+

GPL-2.0-only and MIT?

> +
> +/*
> + * Copyright 2024 NXP
> + */
> +
> +/ {
> +	dsi_ipg_clk: clock-dsi-ipg {

In patch 1, you use clock-controller-x, not very sure which is correct,
but please align.

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <120000000>;
> +		clock-output-names = "dsi_ipg_clk";
> +	};
> +
> +	mipi_pll_div2_clk: clock-mipi-div2-pll {

Ditto.

Regards,
Peng