Re: [PATCH v12 02/13] media: imagination: Add E5010 JPEG Encoder driver

[Devarsh Thakkar]

Hi Sebastian,

On 06/06/24 21:12, Sebastian Fricke wrote:
> Hey Devarsh,
> 
> please see below a warning that I found.
> 
> Otherwise I think the patches are ready, so if you can just send a quick
> fix for that, then I can send the pull requests.
> 
[...]

>> +
>> +static void e5010_stop_streaming(struct vb2_queue *q)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(q);
>> +    struct e5010_q_data *queue;
> 
> drivers/media/platform/imagination/e5010-jpeg-enc.c: In function
> ‘e5010_stop_streaming’:
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1331:30: warning: variable
> ‘queue’ set but not used [-Wunused-but-set-variable]
>  1331 |         struct e5010_q_data *queue;
>       |                              ^~~~~
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1331:30: warning: variable
> ‘queue’ set but not used [-Wunused-but-set-variable]
> 
> Regards,
> Sebastian
> 

Thanks for sharing this.
I have fixed above (and other reported) warnings in V13 series [1]. I have
also shared the delta w.r.t previous series here [2].
Kindly let me know if it looks okay to pull in now or any other comments.

[1]: https://lore.kernel.org/all/20240607131900.3535250-1-devarsht@xxxxxx/
[2]: https://gist.github.com/devarsht/0bd2e90b7352ed4831252a7962fff65d

Regards
Devarsh