Re: [PATCH 2/2] selftests: Add a test mangling with uc_sigmask
From: Mark Brown
Date: Fri Jun 07 2024 - 09:42:56 EST
On Fri, Jun 07, 2024 at 06:53:27PM +0530, Dev Jain wrote:
> On 6/7/24 18:42, Mark Brown wrote:
> > On Fri, Jun 07, 2024 at 05:53:19PM +0530, Dev Jain wrote:
> > > + * Test describing a clear distinction between signal states - delivered and
> > > + * blocked, and their relation with ucontext.
> > This would be clearer if it said more positiviely what the relationship
> > between these things is actually expected to be and how they're tested.
> > Right now it's a bit hard to tell what the test is actually verifying.
> I thought I had described that quite well in the code comments.
> Anyways, I shall incorporate some detail into the initial test
> description too.
If the overview is confusing and people have to read the code to figure
out what it means then that's an issue...
Attachment:
signature.asc
Description: PGP signature