Re: [PATCH v5] checkpatch: check for missing Fixes tags

[Andrew Morton]

On Tue, 11 Jun 2024 16:43:29 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> This check looks for common words that probably indicate a patch
> is a fix.  For now the regex is:
> 
> 	(?:(?:BUG: K.|UB)SAN: |Call Trace:|stable\@|syzkaller)/)
> 
> Why are stable patches encouraged to have a fixes tag?  Some people mark
> their stable patches as "# 5.10" etc.  This is useful but a Fixes tag is
> still a good idea.

I'd say that "# 5.10" is lame and it would be good if checkpatch could
detect this and warn "hey, use a proper Fixes:".  Because

> It  helps people to not cherry-pick buggy patches without also
> cherry-picking the fix.

seems pretty important.