Re: [PATCH 03/14] scsi: fnic: Add support for fabric based solicited requests and responses
From: kernel test robot
Date: Tue Jun 11 2024 - 14:39:24 EST
Hi Karan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.10-rc3 next-20240611]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Karan-Tilak-Kumar/scsi-fnic-Replace-shost_printk-with-pr_info-pr_err/20240611-060227
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20240610215100.673158-4-kartilak%40cisco.com
patch subject: [PATCH 03/14] scsi: fnic: Add support for fabric based solicited requests and responses
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240612/202406120201.VakI9Dly-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240612/202406120201.VakI9Dly-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406120201.VakI9Dly-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
In file included from drivers/scsi/fnic/fnic_fcs.c:21:
drivers/scsi/fnic/fnic_fcs.c: In function 'fdls_send_fcoe_frame':
>> drivers/scsi/fnic/fnic.h:159:33: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Wformat=]
159 | "fnic<%d>: %s: %d: " fmt, fnic_num,\
| ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/fnic/fnic.h:146:25: note: in definition of macro 'FNIC_CHECK_LOGGING'
146 | CMD; \
| ^~~
include/scsi/scsi_host.h:738:9: note: in expansion of macro 'dev_printk'
738 | dev_printk(prefix, &(shost)->shost_gendev, fmt, ##a)
| ^~~~~~~~~~
drivers/scsi/fnic/fnic.h:158:26: note: in expansion of macro 'shost_printk'
158 | shost_printk(kern_level, host, \
| ^~~~~~~~~~~~
drivers/scsi/fnic/fnic_fcs.c:1228:25: note: in expansion of macro 'FNIC_FCS_DBG'
1228 | FNIC_FCS_DBG(KERN_INFO, fnic->lport->host, fnic->fnic_num,
| ^~~~~~~~~~~~
vim +159 drivers/scsi/fnic/fnic.h
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17 149
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 150 #define FNIC_MAIN_DBG(kern_level, host, fnic_num, fmt, args...) \
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17 151 FNIC_CHECK_LOGGING(FNIC_MAIN_LOGGING, \
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 152 shost_printk(kern_level, host, \
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 153 "fnic<%d>: %s: %d: " fmt, fnic_num,\
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 154 __func__, __LINE__, ##args);)
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17 155
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 156 #define FNIC_FCS_DBG(kern_level, host, fnic_num, fmt, args...) \
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17 157 FNIC_CHECK_LOGGING(FNIC_FCS_LOGGING, \
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 158 shost_printk(kern_level, host, \
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 @159 "fnic<%d>: %s: %d: " fmt, fnic_num,\
3df9dd0d51c2e4b Karan Tilak Kumar 2023-12-11 160 __func__, __LINE__, ##args);)
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17 161
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki