Re: [PATCH 2/2] nvme: fix namespace removal list

From: Chaitanya Kulkarni
Date: Wed Jun 12 2024 - 13:21:14 EST


On 6/12/24 08:51, Keith Busch wrote:
> From: Keith Busch<kbusch@xxxxxxxxxx>
>
> This function wants to move a subset of a list from an element to the
> end to another list, so do that with the new list_cut helper instead of
> using the wrong list splice.
>
> Fixes: be647e2c76b27f4 ("nvme: use srcu for iterating namespace list")
> Reported-by: Venkat Rao Bagalkote<venkat88@xxxxxxxxxxxxxxxxxx>
> Tested-by: Venkat Rao Bagalkote<venkat88@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Keith Busch<kbusch@xxxxxxxxxx>

not a blocker, but it'd be really useful if we can get a blktests for this,
I've asked OP to provide steps at least ...

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck