Re: [PATCH 2/2] nvme: fix namespace removal list

[Keith Busch]

On Wed, Jun 12, 2024 at 05:20:48PM +0000, Chaitanya Kulkarni wrote:
> On 6/12/24 08:51, Keith Busch wrote:
> > From: Keith Busch<kbusch@xxxxxxxxxx>
> >
> > This function wants to move a subset of a list from an element to the
> > end to another list, so do that with the new list_cut helper instead of
> > using the wrong list splice.
> >
> > Fixes: be647e2c76b27f4 ("nvme: use srcu for iterating namespace list")
> > Reported-by: Venkat Rao Bagalkote<venkat88@xxxxxxxxxxxxxxxxxx>
> > Tested-by: Venkat Rao Bagalkote<venkat88@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Keith Busch<kbusch@xxxxxxxxxx>
> 
> not a blocker, but it'd be really useful if we can get a blktests for this,
> I've asked OP to provide steps at least ...

Recreate the original report: detach the highest namespace id from your
controller. Let's say it's nsid 10, and let's assume your ctrlid is 0:

  # nvme detach-ns /dev/nvme0 -c 0 -n 10

blktests supposedly has something that detaches namespaces through the
nvmet module, but it doesn't seem to be catching anything.