RE: [PATCH 09/14] scsi: fnic: Modify IO path to use FDLS

From: Karan Tilak Kumar (kartilak)
Date: Tue Jun 18 2024 - 13:36:29 EST


On Wednesday, June 12, 2024 12:19 AM, Hannes Reinecke <hare@xxxxxxx> wrote:
>
> On 6/10/24 23:50, Karan Tilak Kumar wrote:
> > Modify IO path to use FDLS.
> > Add helper functions to process IOs.
> > Remove unused template functions.
> > Cleanup obsolete code.
> > Refactor old function definitions.
> >
> > Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
> > Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
> > Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx>
> > Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
> > ---
> > drivers/scsi/fnic/fnic.h | 20 +-
> > drivers/scsi/fnic/fnic_io.h | 3 +
> > drivers/scsi/fnic/fnic_main.c | 5 +-
> > drivers/scsi/fnic/fnic_scsi.c | 1107 +++++++++++++++++++-------------
> > drivers/scsi/fnic/fnic_stats.h | 2 -
> > 5 files changed, 680 insertions(+), 457 deletions(-)
> >
>
> Well. This patch reverts bascially all changes I did to the fnic driver in converting it to use tagset iterators.
>
> Please update it to stay with tagset iterators.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke Kernel Storage Architect
> hare@xxxxxxx +49 911 74053 688
> SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
>
>

Thanks for pointing this out, Hannes.
Sure, I'll make the required changes in the next version.

Regards,
Karan