Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.
From: Zi Yan
Date: Tue Jun 18 2024 - 15:50:26 EST
On 18 Jun 2024, at 15:44, Andrew Morton wrote:
> On Tue, 18 Jun 2024 09:41:51 -0400 Zi Yan <zi.yan@xxxxxxxx> wrote:
>
>> From: Zi Yan <ziy@xxxxxxxxxx>
>>
>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
>> calling migrate_pages_batch().
>>
>
> Thanks. I'll add
>
> Fixes: 7262f208ca68 ("mm/migrate: split source folio if it is on deferred split list")
>
> and shall queue it for 6.10-rcX.
>
> Please don't forget such details.
I thought about the Fixes tag. Since Hugh's patch fixes the
BUG_ON and VM_BUG_ON, I did not add it here. But yeah stats inconsistency
is something needs to be fixed. Thanks for adding it.
--
Best Regards,
Yan, Zi
Attachment:
signature.asc
Description: OpenPGP digital signature