Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.

From: Huang, Ying
Date: Wed Jun 19 2024 - 03:32:58 EST


Zi Yan <zi.yan@xxxxxxxx> writes:

> From: Zi Yan <ziy@xxxxxxxxxx>
>
> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
> calling migrate_pages_batch().
>
> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

IMHO, we shouldn't ask people to use link to understand the patch
description or commit message. If so, we can make the link less
outstanding and maybe add more words about the issue.

> Suggested-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
> Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>

Otherwise, LGTM, Thanks!

[snip]

--
Best Regards,
Huang, Ying