RE: [EXTERNAL] Re: [net PATCH] octeontx2-pf: Fix linking objects into multiple modules
From: Geethasowjanya Akula
Date: Wed Jun 19 2024 - 08:09:34 EST
From: Simon Horman <horms@xxxxxxxxxx>
Sent: Wednesday, June 19, 2024 4:35 PM
To: Geethasowjanya Akula <gakula@xxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [net PATCH] octeontx2-pf: Fix linking objects into multiple modules
>> This patch fixes the below build warning messages that are
>> caused due to linking same files to multiple modules by
>> exporting the required symbols.
>>
>> "scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
>> otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
>>
>> scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
>> otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvf"
>>
>> Fixes: 8e67558177f8 ("octeontx2-pf: PFC config support with DCBx").
>> Signed-off-by: Geetha sowjanya <mailto:gakula@xxxxxxxxxxx>
>Thanks Geetha,
>I checked and it does not seem to be possible to compile
>rvu_nicvf as a built-in and rvu_nicpf as a module,
>which was my only concern about this.
Yes, it can be ignored as VF can not be enabled without PF driver loaded.
>Reviewed-by: Simon Horman <mailto:horms@xxxxxxxxxx>