Re: [net PATCH] octeontx2-pf: Fix linking objects into multiple modules

From: Simon Horman
Date: Wed Jun 19 2024 - 07:05:43 EST


On Tue, Jun 18, 2024 at 11:41:22AM +0530, Geetha sowjanya wrote:
> This patch fixes the below build warning messages that are
> caused due to linking same files to multiple modules by
> exporting the required symbols.
>
> "scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
> otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
>
> scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
> otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvf"
>
> Fixes: 8e67558177f8 ("octeontx2-pf: PFC config support with DCBx").
> Signed-off-by: Geetha sowjanya <gakula@xxxxxxxxxxx>

Thanks Geetha,

I checked and it does not seem to be possible to compile
rvu_nicvf as a built-in and rvu_nicpf as a module,
which was my only concern about this.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>