Re: [PATCH 2/4] rust: Enable test for macros::module

From: Alice Ryhl
Date: Mon Jun 24 2024 - 04:33:00 EST


On Mon, Jun 24, 2024 at 5:04 AM Ethan D. Twardy <ethan.twardy@xxxxxxxxx> wrote:
>
> Previously, this test was ignored due to a missing necessary dependency
> on the `kernel` crate.
>
> Signed-off-by: Ethan D. Twardy <ethan.twardy@xxxxxxxxx>

It may be worth to call out in the commit message that you are
changing what the example does. (But the change is good - this form of
kernel parameters were never upstreamed.)

With the commit message updated:

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

Oh, also, you don't want an empty line between } and `# fn main() {}`
as it will show up as a weird empty line at the end of the example.

Alice