Re: [PATCH 2/4] rust: Enable test for macros::module
From: Ethan D. Twardy
Date: Wed Jun 26 2024 - 19:06:30 EST
On Mon Jun 24, 2024 at 3:32 AM CDT, Alice Ryhl wrote:
> It may be worth to call out in the commit message that you are
> changing what the example does. (But the change is good - this form of
> kernel parameters were never upstreamed.)
>
> With the commit message updated:
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
> Oh, also, you don't want an empty line between } and `# fn main() {}`
> as it will show up as a weird empty line at the end of the example.
>
> Alice
I have these changes made locally and will send with v2. Thank you!