Re: [PATCH v2] platform/x86: asus-wmi: support the disable camera LED on F10 of Zenbook 2023

[Devin Bayer]

On 24/06/2024 10.17, Ilpo Järvinen wrote:
> On Fri, 21 Jun 2024, Devin Bayer wrote:
> 
>> Adds a sysfs entry for the LED on F10 above the crossed out camera
>> icon on 2023 Zenbooks.
> 
> Please wrap paragraphs at 72 characters.

OK.

>> --- a/include/linux/platform_data/x86/asus-wmi.h
>> +++ b/include/linux/platform_data/x86/asus-wmi.h
>> @@ -50,6 +50,8 @@
>>  #define ASUS_WMI_DEVID_LED5		0x00020015
>>  #define ASUS_WMI_DEVID_LED6		0x00020016
>>  #define ASUS_WMI_DEVID_MICMUTE_LED		0x00040017
>> +#define ASUS_WMI_DEVID_CAMERA_LED_NEG		0x00060078
> 
> This is not used?

No, it does the same as CAMERA_LED but the values are opposite. I
thought it would just be useful as documentation of the WMI functions.

Should I remove it?

>> +#define ASUS_WMI_DEVID_CAMERA_LED		0x00060079
> 
> Why is ASUS_WMI_DEVID_CAMERA_LED added here and into the .c file?

That was a mistake, I used it for testing.

~ Dev