Re: [PATCH net-next v4 04/10] net: psample: allow using rate as probability
From: Paolo Abeni
Date: Tue Jun 25 2024 - 07:17:34 EST
On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
> diff --git a/include/uapi/linux/tc_act/tc_sample.h b/include/uapi/linux/tc_act/tc_sample.h
> index fee1bcc20793..7ee0735e7b38 100644
> --- a/include/uapi/linux/tc_act/tc_sample.h
> +++ b/include/uapi/linux/tc_act/tc_sample.h
> @@ -18,6 +18,7 @@ enum {
> TCA_SAMPLE_TRUNC_SIZE,
> TCA_SAMPLE_PSAMPLE_GROUP,
> TCA_SAMPLE_PAD,
> + TCA_SAMPLE_PROBABILITY,
> __TCA_SAMPLE_MAX
> };
> #define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
I believe Ilya's comment on v3 is correct, this chunk looks unrelated
and unneeded. I guess you can drop it? Or am I missing something?
Thanks,
Paolo