Re: [PATCH net-next v4 04/10] net: psample: allow using rate as probability

[Ilya Maximets]

On 6/25/24 13:17, Paolo Abeni wrote:
> On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
>> diff --git a/include/uapi/linux/tc_act/tc_sample.h b/include/uapi/linux/tc_act/tc_sample.h
>> index fee1bcc20793..7ee0735e7b38 100644
>> --- a/include/uapi/linux/tc_act/tc_sample.h
>> +++ b/include/uapi/linux/tc_act/tc_sample.h
>> @@ -18,6 +18,7 @@ enum {
>>  	TCA_SAMPLE_TRUNC_SIZE,
>>  	TCA_SAMPLE_PSAMPLE_GROUP,
>>  	TCA_SAMPLE_PAD,
>> +	TCA_SAMPLE_PROBABILITY,
>>  	__TCA_SAMPLE_MAX
>>  };
>>  #define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
> 
> I believe Ilya's comment on v3 is correct, this chunk looks unrelated
> and unneeded. I guess you can drop it? Or am I missing something?

Oops, somehow I missed that there is a v4 and replied to v3.
So, my bad.  But yes, the comment still applies here.

Best regards, Ilya Maximets.