Re: [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

[Devi Priya]

On 6/25/2024 8:09 PM, Andrew Lunn wrote:
> > +static struct clk_alpha_pll ubi32_pll_main = {
> > +	.offset = 0x28000,
> > +	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_NSS_HUAYRA],
> > +	.flags = SUPPORTS_DYNAMIC_UPDATE,
> > +	.clkr = {
> > +		.hw.init = &(const struct clk_init_data) {
> > +			.name = "ubi32_pll_main",
> > +			.parent_data = &(const struct clk_parent_data) {
> > +				.index = DT_XO,
> > +			},
> > +			.num_parents = 1,
> > +			.ops = &clk_alpha_pll_huayra_ops,
> > +		},
> > +	},
> > +};
> > +
> > +static struct clk_alpha_pll_postdiv ubi32_pll = {
> > +	.offset = 0x28000,
> > +	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_NSS_HUAYRA],
> > +	.width = 2,
> > +	.clkr.hw.init = &(const struct clk_init_data) {
> > +		.name = "ubi32_pll",
> > +		.parent_hws = (const struct clk_hw *[]) {
> > +			&ubi32_pll_main.clkr.hw
> > +		},
> > +		.num_parents = 1,
> > +		.ops = &clk_alpha_pll_postdiv_ro_ops,
> > +		.flags = CLK_SET_RATE_PARENT,
> > +	},
> > +};
>
> Can these structures be made const? You have quite a few different
> structures in this driver, some of which are const, and some which are
> not.
Sure, will check and update this in V6

Thanks,
Devi Priya
> 	Andrew