Re: [PATCH v2] s390/ism: Add check for dma_set_max_seg_size in ism_probe()

[Ratheesh Kannoth]

On 2024-06-27 at 07:43:14, Ma Ke (make24@xxxxxxxxxxx) wrote:
> As the possible failure of the dma_set_max_seg_size(), we should better
Could you expand on the scenario of failure ?
> check the return value of the dma_set_max_seg_size().

> +++ b/drivers/s390/net/ism_drv.c
> @@ -620,7 +620,10 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		goto err_resource;
>
>  	dma_set_seg_boundary(&pdev->dev, SZ_1M - 1);
> -	dma_set_max_seg_size(&pdev->dev, SZ_1M);
> +	ret = dma_set_max_seg_size(&pdev->dev, SZ_1M);
Same error check is not valid for dma_set_seg_boundary() ?

>