Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode
From: Matthew Wilcox
Date: Thu Jun 27 2024 - 17:48:09 EST
On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote:
> /*
> - * Currently, the only defined flags are mutually exclusive
> + * The below two flags are mutually exclusive:
> */
> if (flags & MPOL_F_STATIC_NODES)
> p += snprintf(p, buffer + maxlen - p, "static");
> else if (flags & MPOL_F_RELATIVE_NODES)
> p += snprintf(p, buffer + maxlen - p, "relative");
> +
> + if (flags & MPOL_F_NUMA_BALANCING)
> + p += snprintf(p, buffer + maxlen - p, "balancing");
> }
So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we
get a string "staticbalancing"? Is that intended?
Or are these three all mutually exclusive and that should have been
as "else if"?