RE: [EXTERNAL] Re: [PATCH v9 6/9] spi: cadence: Add Marvell xfer operation support

[Witold Sadowski]

Hi Mark

> 
> > +		while (t->len) {
> > +
> > +			current_cycle_count = t->len > max_len ? max_len : t-
> >len;
> 
> cycle_count seems like a weird name?
> 
> In general please try to avoid overusing the ternery operator, it doesn't
> help legibility.  Just write normal conditional statements, or in this
> case use max().

Will be addressed in next patchset.

> 
> > +				cdns_xspi->current_xfer_qword +=
> current_cycle_count /
> > +
> MRVL_XFER_QWORD_BYTECOUNT;
> > +				if (current_cycle_count %
> MRVL_XFER_QWORD_BYTECOUNT)
> > +					cdns_xspi->current_xfer_qword++;
> > +
> > +				cdns_xspi->current_xfer_qword %=
> MRVL_XFER_QWORD_COUNT;
> > +			}
> > +			cs_change = t->cs_change;
> > +			t->len -= current_cycle_count;
> > +		}
> > +	}
> 
> This loop doesn't implement any of the delay stuff, ideally it either
> would or would reject transfers that request transfers.

I'm not sure about what kind of the delay You are referring to. Can You explain?

Regards
Witek