Re: [PATCH 1/4] cpupower: Add 'help' target to the 'bench' subproject makefile

[Shuah Khan]

On 6/23/24 13:19, Roman Storozhenko wrote:
> Add 'help' target, describing all user-available targets, to the
> 'bench' subproject makefile.
>
> Signed-off-by: Roman Storozhenko <romeusmeister@xxxxxxxxx>
> ---
>   tools/power/cpupower/bench/Makefile | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile
> index a4b902f9e1c4..81c862297782 100644
> --- a/tools/power/cpupower/bench/Makefile
> +++ b/tools/power/cpupower/bench/Makefile
> @@ -41,3 +41,15 @@ install: $(OUTPUT)cpufreq-bench
>   clean:
>   	rm -f $(OUTPUT)*.o
>   	rm -f $(OUTPUT)cpufreq-bench
> +
> +help:
> +	@echo  'Build targets:'
> +	@echo  '  all		  - Default target. Could be omitted. Put build artifacts'
> +	@echo  '                    to "O" cmdline option dir (default: current dir)'
> +	@echo  '  install	  - Install previously built project files from the output'
> +	@echo  '                    dir defined by "O" cmdline option (default: current dir)'
> +	@echo  '                    to the install dir  defined by "DESTDIR" cmdline'
> +	@echo  ''
> +	@echo  'Clean targets:'
> +	@echo  '  clean		  - Clean build artifacts from the dir defined by "O" cmdline'
> +	@echo  '                    option (default: current dir)'

Is this help message necessary if bench can't be built standalone?

cpupower: Disable direct build of the 'bench' subproject
https://patchwork.kernel.org/project/linux-pm/patch/20240626-fix_bench_compilation-v1-1-d039bd5fa551@xxxxxxxxx/

thanks,
-- Shuah