Re: [RFC PATCH v14 0/8] TPEBS counting mode support

[Namhyung Kim]

Hello Weilin,

On Mon, Jul 1, 2024 at 9:27 PM Wang, Weilin <weilin.wang@xxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Wang, Weilin
> > Sent: Saturday, June 29, 2024 10:13 PM
> > To: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Cc: Ian Rogers <irogers@xxxxxxxxxx>; Arnaldo Carvalho de Melo
> > <acme@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo Molnar
> > <mingo@xxxxxxxxxx>; Alexander Shishkin
> > <alexander.shishkin@xxxxxxxxxxxxxxx>; Jiri Olsa <jolsa@xxxxxxxxxx>; Hunter,
> > Adrian <adrian.hunter@xxxxxxxxx>; Kan Liang <kan.liang@xxxxxxxxxxxxxxx>;
> > linux-perf-users@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Taylor, Perry
> > <perry.taylor@xxxxxxxxx>; Alt, Samantha <samantha.alt@xxxxxxxxx>; Biggers,
> > Caleb <caleb.biggers@xxxxxxxxx>
> > Subject: RE: [RFC PATCH v14 0/8] TPEBS counting mode support
> >
> >
> >
> > > -----Original Message-----
> > > From: Namhyung Kim <namhyung@xxxxxxxxxx>
> > > Sent: Thursday, June 27, 2024 1:32 PM
> > > To: Wang, Weilin <weilin.wang@xxxxxxxxx>
> > > Cc: Ian Rogers <irogers@xxxxxxxxxx>; Arnaldo Carvalho de Melo
> > > <acme@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo Molnar
> > > <mingo@xxxxxxxxxx>; Alexander Shishkin
> > > <alexander.shishkin@xxxxxxxxxxxxxxx>; Jiri Olsa <jolsa@xxxxxxxxxx>; Hunter,
> > > Adrian <adrian.hunter@xxxxxxxxx>; Kan Liang <kan.liang@xxxxxxxxxxxxxxx>;
> > > linux-perf-users@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Taylor, Perry
> > > <perry.taylor@xxxxxxxxx>; Alt, Samantha <samantha.alt@xxxxxxxxx>;
> > Biggers,
> > > Caleb <caleb.biggers@xxxxxxxxx>
> > > Subject: Re: [RFC PATCH v14 0/8] TPEBS counting mode support
> > >
> > > On Wed, Jun 26, 2024 at 06:17:22PM +0000, Wang, Weilin wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Namhyung Kim <namhyung@xxxxxxxxxx>
> > > > > Sent: Wednesday, June 26, 2024 10:59 AM
> > > > > To: Wang, Weilin <weilin.wang@xxxxxxxxx>
> > > > > Cc: Ian Rogers <irogers@xxxxxxxxxx>; Arnaldo Carvalho de Melo
> > > > > <acme@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo Molnar
> > > > > <mingo@xxxxxxxxxx>; Alexander Shishkin
> > > > > <alexander.shishkin@xxxxxxxxxxxxxxx>; Jiri Olsa <jolsa@xxxxxxxxxx>;
> > Hunter,
> > > > > Adrian <adrian.hunter@xxxxxxxxx>; Kan Liang
> > <kan.liang@xxxxxxxxxxxxxxx>;
> > > > > linux-perf-users@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Taylor,
> > > Perry
> > > > > <perry.taylor@xxxxxxxxx>; Alt, Samantha <samantha.alt@xxxxxxxxx>;
> > > Biggers,
> > > > > Caleb <caleb.biggers@xxxxxxxxx>
> > > > > Subject: Re: [RFC PATCH v14 0/8] TPEBS counting mode support
> > > > >
> > > > > On Mon, Jun 24, 2024 at 06:20:16PM -0400, weilin.wang@xxxxxxxxx
> > > wrote:
> > > > > > From: Weilin Wang <weilin.wang@xxxxxxxxx>
> > > > > >
> > > > > > Changes in v14:
> > > > > >  - Fix the python import test failure. We cannot support PYTHON_PERF
> > > > > because it
> > > > > >  will trigger a chain of dependency issues if we add intel-tpebs.c to it.
> > So,
> > > > > >  only enable tpebs functions in evsel and evlist when PYTHON_PERF is
> > not
> > > > > >  defined.
> > > > >
> > > > > I think it's easier if we have Ian's python build cleanup first.
> > > > >
> > > > >   https://lore.kernel.org/linux-perf-users/20240625214117.953777-1-
> > > > > irogers@xxxxxxxxxx
> > > > >
> > > > > Let me take a look at it..
> > > >
> > > > Ok, I will hold the cmd option name update until we conclude on this one.
> > > > Thanks a lot!
> > >
> > > Please take a look at the current perf-tools-next branch.
> >
> > Hi Namhyung,
> >
> > The python import test works correctly with the latest perf-tools-next branch
> > without the change I added in v14. I will send a new version that reverts this
> > change and update the command line option. Is there any other changes
> > you'd
> > like me to add?
>
> Hi Namhyung,
>
> I'm planning to submit the new version before Wednesday. Please let me know if
> you have any new comment on this.

Yep, I think it's ok unless it introduces new test failures.

Thanks,
Namhyung