Re: [PATCH net-next v2 3/3] net: dsa: microchip: lan937x: disable VPHY support

[Arun.Ramadoss]

Hi Oleksij,


> ---
>  drivers/net/dsa/microchip/lan937x_main.c | 3 +++
>  drivers/net/dsa/microchip/lan937x_reg.h  | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/lan937x_main.c
> b/drivers/net/dsa/microchip/lan937x_main.c
> index eaa862eb6b265..0606796b14856 100644
> --- a/drivers/net/dsa/microchip/lan937x_main.c
> +++ b/drivers/net/dsa/microchip/lan937x_main.c
> @@ -390,6 +390,9 @@ int lan937x_setup(struct dsa_switch *ds)
>         lan937x_cfg(dev, REG_SW_GLOBAL_OUTPUT_CTRL__1,
>                     (SW_CLK125_ENB | SW_CLK25_ENB), true);
> 
> +       /* Disable global VPHY support. Related to CPU interface
> only? */
> +       ksz_rmw32(dev, REG_SW_CFG_STRAP_OVR, SW_VPHY_DISABLE,
> SW_VPHY_DISABLE);

Do we need to check the return value of ksz_rmw32?

> +
>         return 0;
>  }
> 
>