Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak

From: Tejun Heo
Date: Wed Jul 03 2024 - 14:03:13 EST


On Wed, Jul 03, 2024 at 03:13:29PM +0530, Kamalesh Babulal wrote:
...
> The patch looks good to me after the atomic conversion. Sorry for bringing up
> this question so late into the discussion. Given that misc.max is available
> only for non-root cgroups, does it make sense for misc.peak too, available
> for non-root cgroups only?

It's more tied to the usage - misc.current. For memcg, memory.current is
only on non-root cgroups, so is peak. For misc, as misc.current exists for
the root cgroup, it makes sense for .peak to be there too.

Thanks.

--
tejun