Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak

From: Kamalesh Babulal
Date: Thu Jul 04 2024 - 01:55:47 EST




On 7/3/24 11:33 PM, Tejun Heo wrote:
> On Wed, Jul 03, 2024 at 03:13:29PM +0530, Kamalesh Babulal wrote:
> ...
>> The patch looks good to me after the atomic conversion. Sorry for bringing up
>> this question so late into the discussion. Given that misc.max is available
>> only for non-root cgroups, does it make sense for misc.peak too, available
>> for non-root cgroups only?
>
> It's more tied to the usage - misc.current. For memcg, memory.current is
> only on non-root cgroups, so is peak. For misc, as misc.current exists for
> the root cgroup, it makes sense for .peak to be there too.
>

Thank you so much for explaining in the context of misc controller.

--
Thanks,
Kamalesh