Re: [PATCH net] wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter()

From: Kalle Valo
Date: Thu Jul 04 2024 - 05:53:25 EST


Aleksandr Mishin <amishin@xxxxxxxxxx> writes:

> In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size.
> But then 'rate->he_gi' is used as array index instead of 'status->he_gi'.
> This can lead to go beyond array boundaries in case of 'rate->he_gi' is
> not equal to 'status->he_gi' and is bigger than array size. Looks like
> "copy-paste" mistake.
>
> Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>

A reminder for maintainers: rtw89 patches go to Ping's rtw tree, not net
tree.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches