Re: [PATCH net] wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter()
From: Ping-Ke Shih
Date: Thu Jul 04 2024 - 22:06:27 EST
Aleksandr Mishin <amishin@xxxxxxxxxx> wrote:
> In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size.
> But then 'rate->he_gi' is used as array index instead of 'status->he_gi'.
> This can lead to go beyond array boundaries in case of 'rate->he_gi' is
> not equal to 'status->he_gi' and is bigger than array size. Looks like
> "copy-paste" mistake.
>
> Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
85099c7ce4f9 wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter()
---
https://github.com/pkshih/rtw.git