RE: [PATCH 04/10] iio: adc: ad7091r8: Constify struct regmap_bus
From: Schmitt, Marcelo
Date: Thu Jul 04 2024 - 09:05:16 EST
> From: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> Sent: Wednesday, July 3, 2024 6:05 PM
> To: Tanislav, Cosmin <Cosmin.Tanislav@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Dan Robertson <dan@xxxxxxxxxxxxxxx>; Schmitt, Marcelo <Marcelo.Schmitt@xxxxxxxxxx>; Sa, Nuno > <Nuno.Sa@xxxxxxxxxx>; Jagath Jog J <jagathjog1996@xxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> Subject: [PATCH 04/10] iio: adc: ad7091r8: Constify struct regmap_bus
>
> `ad7091r8_regmap_bus` is not modified and can be declared as const to move its data to a read-only section.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> drivers/iio/adc/ad7091r8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c index 700564305057..c9e014d6a77c 100644
> --- a/drivers/iio/adc/ad7091r8.c
> +++ b/drivers/iio/adc/ad7091r8.c
> @@ -159,7 +159,7 @@ static int ad7091r_regmap_bus_reg_write(void *context, unsigned int reg,
> return spi_write(spi, &st->tx_buf, 2); }
>
> -static struct regmap_bus ad7091r8_regmap_bus = {
> +static const struct regmap_bus ad7091r8_regmap_bus = {
> .reg_read = ad7091r_regmap_bus_reg_read,
> .reg_write = ad7091r_regmap_bus_reg_write,
> .reg_format_endian_default = REGMAP_ENDIAN_BIG,