Re: [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns()

From: Borislav Petkov
Date: Fri Jul 05 2024 - 05:45:36 EST


On Thu, Jul 04, 2024 at 07:45:00PM -0700, H. Peter Anvin wrote:
> Except that that would be more cleanly spelled wrmsrns()... let's just
> abstract the whole thing away and let the user use wrmsrns() whenever
> serialization is not necessary.

Just don't make it more complex and unreadable than it has to be.

cpu_feature_enabled() already is patching things for optimal perf so even if
PeterZ prefers the alternative, I say it is ugly and, more importantly,
unnecessary.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette