Re: [PATCH] Revert "firewire: ohci: use common macro to interpret be32 data in le32 buffer"

[Takashi Sakamoto]

On Sun, Jul 07, 2024 at 10:45:23PM +0900, Takashi Sakamoto wrote:
> This reverts commit f26a38e61c03fdfacb6b596e1daf665cf4526a60, since it
> causes the following sparse warnings:
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/firewire/ohci.c:891:23: sparse: sparse: cast to restricted __be32
> >> drivers/firewire/ohci.c:891:23: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:892:23: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:892:23: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:893:23: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:893:23: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:905:31: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:905:31: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:914:31: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:914:31: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:939:18: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:939:18: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:2033:23: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:2033:23: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:2037:27: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:2037:27: sparse: sparse: cast from restricted __le32
>    drivers/firewire/ohci.c:2038:27: sparse: sparse: cast to restricted __be32
>    drivers/firewire/ohci.c:2038:27: sparse: sparse: cast from restricted __le32
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407050656.03bw1YXA-lkp@xxxxxxxxx/
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
>  drivers/firewire/ohci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next branch.


Regards

Takashi Sakamoto