Re: [PATCH] dt-bindings: mmc: sdhci-sprd: convert to YAML

From: Krzysztof Kozlowski
Date: Mon Jul 08 2024 - 03:42:29 EST


On 06/07/2024 15:33, Stanislav Jakubek wrote:
> Covert the Spreadtrum SDHCI controller bindings to DT schema.
> Rename the file to match compatible.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx>
> ---
> Node name adjustments in DTS are being handled as part of:
> https://lore.kernel.org/lkml/cover.1720112081.git.stano.jakubek@xxxxxxxxx/

Thanks

> + clocks:
> + minItems: 2
> + items:
> + - description: SDIO source clock
> + - description: gate clock for enabling/disabling the device
> + - description: gate clock controlling the device for some special platforms (optional)
> +
> + clock-names:
> + minItems: 2
> + items:
> + - const: sdio
> + - const: enable
> + - const: 2x_enable
> +
> + assigned-clocks:
> + maxItems: 1
> +
> + assigned-clock-parents:
> + maxItems: 1

Drop both assigned-... properties, should not be needed.

> +
> + pinctrl-0:
> + description: default/high speed pin control
> + maxItems: 1
> +

Rest looks good, so with above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof