Re: [PATCH v2 0/5] ACPI: sysfs: manage sysfs attributes through device core

From: Thomas Weißschuh
Date: Wed Jul 10 2024 - 07:50:05 EST


On 2024-07-10 13:43:57+0000, Rafael J. Wysocki wrote:
> On Tue, Jul 9, 2024 at 10:38 PM Thomas Weißschuh <linux@xxxxxxxxxxxxxx> wrote:
> >
> > Simplify the lifecycle of the sysfs attributes by letting the device
> > core manage them.
> >
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Add fix to validate buffer type validation (patch 1)
> > - Drop usage of devm-APIs as these are unusable for unbound devices
> > - Evaluate _STR on each sysfs access
> > - Link to v1: https://lore.kernel.org/r/20240613-acpi-sysfs-groups-v1-0-665e0deb052a@xxxxxxxxxxxxxx
> >
> > ---
> > Thomas Weißschuh (5):
> > ACPI: sysfs: validate return type of _STR method
> > ACPI: sysfs: evaluate _STR on each sysfs access
> > ACPI: sysfs: manage attributes as attribute_group
> > ACPI: sysfs: manage sysfs attributes through device core
> > ACPI: sysfs: remove return value of acpi_device_setup_files()
> >
> > drivers/acpi/device_sysfs.c | 196 +++++++++++++++++++-------------------------
> > drivers/acpi/internal.h | 3 +-
> > drivers/acpi/scan.c | 6 +-
> > include/acpi/acpi_bus.h | 1 -
> > 4 files changed, 89 insertions(+), 117 deletions(-)
> > ---
>
> If this is not urgent, and I don't think it is, I'd rather defer it to
> the 6.12 cycle (that is, I'd apply it after the upcoming 6.11 merge
> window).

Sounds good to me.


Thanks,
Thomas