Re: [PATCH] usb: gadget: uvc: Add H264 frame format support

From: Greg Kroah-Hartman
Date: Wed Jul 10 2024 - 07:51:57 EST


On Mon, Jul 08, 2024 at 09:43:28AM +0530, Akash Kumar wrote:
> Add support for framebased frame format which can be used to support
> multiple formats like H264 or H265 other than mjpeg and YUV frames.
>
> Framebased format is set to H264 by default, which can be updated to
> other formats by updating the GUID through guid configfs attribute.
>
> Signed-off-by: Akash Kumar <quic_akakum@xxxxxxxxxxx>
> ---
> drivers/usb/gadget/function/uvc_configfs.c | 570 ++++++++++++++++++---
> drivers/usb/gadget/function/uvc_configfs.h | 34 +-
> drivers/usb/gadget/function/uvc_v4l2.c | 80 ++-
> include/uapi/linux/usb/video.h | 62 +++
> 4 files changed, 638 insertions(+), 108 deletions(-)

DOn't you need to add the new configfs entries to Documentation/ABI/?

And how is anyone going to know about this new api or format if there
are not new files? WHere is it now documented?

thanks,

greg k-h