Re: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting

[Serge Semin]

On Tue, Jul 09, 2024 at 01:35:22PM +0200, Borislav Petkov wrote:
> On Thu, Jun 27, 2024 at 08:32:09PM +0300, Serge Semin wrote:
> > The mem_ctl_info.scrub_cap field is supposed to be set with the ECC
> > scrub-related flags. Instead the driver erroneously initializes it with
> > the SCRUB_HW_SRC flag ID. It's definitely wrong, but it hasn't caused any
> > problem so far since the structure field isn't used by the EDAC core. Fix
> > it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field.
> 
> This hasn't been used at least since it got added by
> 
> commit da9bb1d27b21cb24cbb6a2efb5d3c464d357a01e
> Author: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Date:   Wed Jan 18 17:44:13 2006 -0800
> 
>     [PATCH] EDAC: core EDAC support code
> 
> AFAICT.
> 
> Please remove ->scrub_cap along with enum scrub_type instead.
> 
> We can always resurrect it if needed.

Agreed. I'll drop all of these from the EDAC core and drivers.

-Serge(y)

> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette