Re: [PATCH] driver:core: no need to set a default value for want_async

From: Greg KH
Date: Thu Jul 11 2024 - 11:13:34 EST


On Thu, Jul 11, 2024 at 08:05:45AM -0700, 李哲 wrote:
> The default value of this member variable is false,
> which is only set to true when asynchronous loading is required,
> and does not need to be set to false during synchronization
>
> Signed-off-by: 李哲 <sensor1010@xxxxxxx>
> ---
> drivers/base/dd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index d047919d1f5e..47351d98f6e1 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1014,7 +1014,6 @@ static int __device_attach(struct device *dev, bool allow_async)
> struct device_attach_data data = {
> .dev = dev,
> .check_async = allow_async,
> - .want_async = false,

This is good to keep as-is for documentation alone, it doesn't actually
change anything and makes it obvious.

thanks,

greg k-h