Re: [PATCH v3 1/2] arm64: dts: rockchip: Add sdmmc_ext for RK3328

From: Dragan Simic
Date: Sat Jul 13 2024 - 10:58:57 EST


Hello Alex,

On 2024-07-13 16:56, Alex Bee wrote:
Am 13.07.24 um 16:35 schrieb Diederik de Haas:
Hi Dragan,

Thanks for the reviews!

On Saturday, 13 July 2024 15:45:12 CEST Dragan Simic wrote:
Looking good to me, cross-referencing the RK3328 TRM and the
downstream RK3328 SoC dtsi checks out. Though, it will remain inert
in our codebase, because no supported boards use it, but that's fine,
we're still improving the correctness of the RK3328 SoC dtsi.
Indeed. But it's hard to argue with technically correct ;-)

FWIW: (upstream supported) ROC-RK3328-PC has sdio wifi connected to this
controller.

Oh, it does? Good to hear, so the additions to the RK3328 SoC dtsi
shouldn't remain inert. :)