Re: [PATCH v3 2/2] mm: zswap: fix global shrinker error handling logic

[Takero Funaki]

2024年7月27日(土) 3:01 Nhat Pham <nphamcs@xxxxxxxxx>:
>
> On Fri, Jul 26, 2024 at 1:54 AM Takero Funaki <flintglass@xxxxxxxxx> wrote:
> >
> > Yes, the `++progress` counts both error and success as an iteration
> > progress for valid memcgs (not writeback amount). Incrementing only on
> > success will overly increment failures counter if there is only one
> > memcg, one from writeback failure and one from tree walk ends, the
> > worker aborts on 8 failures instead of 16.
> > `++candidates;` would be better? replacing the name and fixing commit
> > messages for v4.
>
> How about `attempt` or `attempted`? Naming is hard :)

Thanks. Rewriting with `attempts` in align with the `failures` counter.