Re: [PATCH v4 2/3] iio: pressure: Add driver for Sensirion SDP500

From: Krzysztof Kozlowski
Date: Sun Jul 28 2024 - 05:12:57 EST


On 25/07/2024 17:37, Petar Stoykov via B4 Relay wrote:
> From: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
>
> Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> accessed over I2C.
>
> Signed-off-by: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
> ---

> +
> +static const struct i2c_device_id sdp500_id[] = {
> + { "sdp500" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, sdp500_id);
> +
> +static const struct of_device_id sdp500_of_match[] = {
> + { .compatible = "sensirion,sdp500" },
> + { .compatible = "sensirion,sdp510" },

Drop, why do you need it? I asked about this last time. Also, your OF
table is not in sync with I2C table, so this should raise questions.

Best regards,
Krzysztof