Re: [PATCH v4 2/3] iio: pressure: Add driver for Sensirion SDP500

[Jonathan Cameron]

On Sun, 28 Jul 2024 11:12:45 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> On 25/07/2024 17:37, Petar Stoykov via B4 Relay wrote:
> > From: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
> > 
> > Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> > accessed over I2C.
> > 
> > Signed-off-by: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
> > ---  
> 
> > +
> > +static const struct i2c_device_id sdp500_id[] = {
> > +	{ "sdp500" },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, sdp500_id);
> > +
> > +static const struct of_device_id sdp500_of_match[] = {
> > +	{ .compatible = "sensirion,sdp500" },
> > +	{ .compatible = "sensirion,sdp510" },  
> 
> Drop, why do you need it? I asked about this last time. Also, your OF
> table is not in sync with I2C table, so this should raise questions.
> 

Agreed. I dropped the sdp510 entry whilst applying.
Petar, if that is wrong for some reason we are missing, then shout.
This won't go upstream for a little while yet so we can always put
it back again :)

Jonathan

> Best regards,
> Krzysztof
>