Re: [PATCH v4 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device

From: Krzysztof Kozlowski
Date: Mon Jul 29 2024 - 03:35:26 EST


On 29/07/2024 09:00, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

Why? Which devices have it? If only your newest addon, then squash the
patches and add appropriate allOf:if:then disallowing the clocks for
others. Or maybe all of them have it? Why commit msg does not explain
anything about the hardware?

>
> Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
> ---

Best regards,
Krzysztof