Re: [PATCH] power: sequencing: pwrseq-qcom-wcn: Depend on WCN36XX

From: Bartosz Golaszewski
Date: Mon Jul 29 2024 - 04:13:03 EST


On Thu, Jul 25, 2024 at 6:28 PM Andrew Halaney <ahalaney@xxxxxxxxxx> wrote:
>
> This driver does sequencing for the hardware driven by WCN36XX, let's
> make it depend on that. Without WCN36XX, we're sequencing power for
> nothing.
>
> Fixes: 2f1630f437df ("power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets")
> Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
> ---
> I *think* this makes sense, but if you disagree please let me know. I
> was sorting out configs in fedora and noticed this was being asked for
> builds that didn't have WCN36XX enabled, which seems odd to me at least.
> ---
> drivers/power/sequencing/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/sequencing/Kconfig b/drivers/power/sequencing/Kconfig
> index c9f1cdb665248..a4765cb33a80e 100644
> --- a/drivers/power/sequencing/Kconfig
> +++ b/drivers/power/sequencing/Kconfig
> @@ -16,6 +16,7 @@ if POWER_SEQUENCING
> config POWER_SEQUENCING_QCOM_WCN
> tristate "Qualcomm WCN family PMU driver"
> default m if ARCH_QCOM
> + depends on WCN36XX
> help
> Say Y here to enable the power sequencing driver for Qualcomm
> WCN Bluetooth/WLAN chipsets.
>
> ---
> base-commit: 2347b4c79f5e6cd3f4996e80c2d3c15f53006bf5
> change-id: 20240725-pwrseq-wcn-config-0b6668b5c620
>
> Best regards,
> --
> Andrew Halaney <ahalaney@xxxxxxxxxx>
>

What if we want to disable the WLAN driver but keep the Bluetooth
driver enabled?

Bart